Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-illustrated-message): added new illustrations #6701

Merged
merged 3 commits into from
Mar 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fiori/src/IllustratedMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ class IllustratedMessage extends UI5Element {
* <li><code>FilterTable</code></li>
* <li><code>GroupTable</code></li>
* <li><code>NoActivities</code></li>
* <li><code>NoColumnsSet</code></li>
* <li><code>NoData</code></li>
* <li><code>NoEntries</code></li>
* <li><code>NoFilterResults</code></li>
Expand Down
6 changes: 6 additions & 0 deletions packages/fiori/src/i18n/messagebundle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,12 @@ IM_TITLE_NOACTIVITIES=You''ve not added any activities yet
#XTXT: IllustratedMessage's subtitle for the NoActivities illustration
IM_SUBTITLE_NOACTIVITIES=Would you like to add one now?

#XTIT: IllustratedMessage's title for the NoColumnsSet illustration
IM_TITLE_NOCOLUMNSSET=Add columns to see the content

#XTIT: IllustratedMessage's subtitle for the NoColumnsSet illustration
IM_SUBTITLE_NOCOLUMNSSET=Select the columns you need in the table settings.

#XTIT: IllustratedMessage's title for the NoData illustration
IM_TITLE_NODATA=There''s no data yet

Expand Down
35 changes: 35 additions & 0 deletions packages/fiori/src/illustrations/sapIllus-Dialog-NoColumnsSet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
36 changes: 36 additions & 0 deletions packages/fiori/src/illustrations/sapIllus-Scene-NoColumnsSet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
36 changes: 36 additions & 0 deletions packages/fiori/src/illustrations/sapIllus-Spot-NoColumnsSet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 6 additions & 0 deletions packages/fiori/src/types/IllustrationMessageType.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,12 @@ enum IllustrationMessageType {
* @type {NoActivities}
*/
NoActivities = "NoActivities",
/**
* "No Columns Set" illustration type.
* @public
* @type {NoColumnsSet}
*/
NoColumnsSet = "NoColumnsSet",
/**
* "No Data" illustration type.
* @public
Expand Down
1 change: 1 addition & 0 deletions packages/fiori/test/pages/IllustratedMessage.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
<ui5-option>FilterTable</ui5-option>
<ui5-option>GroupTable</ui5-option>
<ui5-option>NoActivities</ui5-option>
<ui5-option>NoColumnsSet</ui5-option>
<ui5-option>NoData</ui5-option>
<ui5-option>NoEntries</ui5-option>
<ui5-option>NoFilterResults</ui5-option>
Expand Down