feat(ui5-time-picker): Redesign the Time Picker component according to the new design #6818
Conversation
There was a problem hiding this comment.
The PR says:
"refactor(ui5-time-picker): Redesign the Time Picker component according to the new design"
but there is no redesign of the TimePicker, it's a PR that adds private web component (that I assume will be used later with another changed in the TimePicker). The PR description needs adjustments.
I will change "refactor" with "wip" - in fact the component that is currently in this PR cannot (and have no idea to) be used separately. There will be at least two more components (also private and useless outside Time Picker context) included in this PR and all of them then will be used in the refactoring. BR, |
NHristov-sap
changed the title
|
Hello, the redesign is still in process, that's why I am reopening this PR. |
NHristov-sap
force-pushed
the
BL_timepicker_redesign
branch
from
736511c to
7a5e86a
Compare
NHristov-sap
dismissed stale reviews from ilhan007 and vladitasev
It is already fixed
ilhan007
changed the title
…o the new design (#6818) * WIP(ui5-time-picker-clock): initial implementation * feat(ui5-time-picker-clock): initial implementation * feat(ui5-time-picker-clock) mark component as private * time selection with clocks - updated main * optimization and time selection methods integration, part 1 * wip(ui5-time-picker): replace sliders with clocks * feat(ui5-time-picker): fix lint errors * add initial tests * feat(ui5-time-picker): fix comments and add tests * feat(ui5-time-picker): fix comments * feat(ui5-time-picker): fix comments and tests * feat(ui5-time-picker): fix latest comments * feat(ui5-time-picker): fix comments for tests and global event
|
Related to: #3678 |
The Time Picker component will be redesigned according to the new design with clocks, already provided for UI5 TimePicker control.
Instead of currently existing sliders, new clock dial components whould be used to select time (hours/minutes/seconds, each selected by separate clock). Also, there is AM/PM segmented button that replaces the AM/PM slider.
In addition to mouse, touch or mouse wheel time selection, there is improved keyboard interaction added - hours/minutes and seconds can be selected by keyboard ([PageUp]/[PageDown] for hours, [Shift]+[PageUp]/[PageDown] for minutes and [Ctrl/Cmd]+[Shift]+[PageUp]/[PageDown] for seconds as well as [A] or [P] for AM/PM selection). Also, direct number typing is accepted.
Accessibility/SR announcements are also covered.