feat(ui5-title): add custom overstyles when used with Link #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases when a Link will be used inside a Title. A subtle link will look like a default link when it is used inside a title. Refactored Link to allow for overstyling. Fixes #6785
dimovpetar
requested changes
Apr 25, 2023
dimovpetar
approved these changes
Apr 26, 2023
BorisDafov
suggested changes
Apr 26, 2023
BorisDafov
reviewed
Apr 26, 2023
dimovpetar
approved these changes
Apr 26, 2023
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
There are cases when a Link will be used inside a Title. Elements nested inside, mainly the Link, will inherit the Title's font styles. Refactored Link to allow for overstyling. Updated text-underline when hovering a Subtle link to match the latest VD spec. Fixes #6785
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jun 20, 2023
There are cases when a Link will be used inside a Title. Elements nested inside, mainly the Link, will inherit the Title's font styles. Refactored Link to allow for overstyling. Updated text-underline when hovering a Subtle link to match the latest VD spec. Fixes #6785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases when a Link will be used inside a Title.
Elements nested inside, mainly the Link, will inherit the Title's font styles.
Refactored Link to allow for overstyling. Updated text-underline when hovering a Subtle link to match the latest VD spec.
Fixes #6785