Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-upload-collеction): align buttons to avoid extra space when size is small #7491

Merged
merged 7 commits into from
Sep 13, 2023
Merged

fix(ui5-upload-collеction): align buttons to avoid extra space when size is small #7491

merged 7 commits into from
Sep 13, 2023

Conversation

dimovpetar
Copy link
Contributor

@dimovpetar dimovpetar commented Aug 25, 2023 •
edited
Loading

  • Fixed buttons position on Horizon and Quartz themes when width is below 30rem
  • Replaced media queries with container queries

@dimovpetar dimovpetar changed the title fix(ui5-upload-collcetion): buttons now wrap on new row for Fiori 3 and Horizon themes WIP(ui5-upload-collcetion): buttons now wrap on new row for Fiori 3 and Horizon themes Aug 25, 2023
@dimovpetar dimovpetar changed the title WIP(ui5-upload-collcetion): buttons now wrap on new row for Fiori 3 and Horizon themes WIP(ui5-upload-collеction): buttons now wrap on new row for Fiori 3 and Horizon themes Aug 25, 2023
@dimovpetar dimovpetar changed the title WIP(ui5-upload-collеction): buttons now wrap on new row for Fiori 3 and Horizon themes fix(ui5-upload-collеction): buttons now wrap on new row for Fiori 3 and Horizon themes Sep 4, 2023
@dimovpetar dimovpetar changed the title fix(ui5-upload-collеction): buttons now wrap on new row for Fiori 3 and Horizon themes fix(ui5-upload-collеction): align buttons to avoid extra space when size is small Sep 4, 2023
@dimovpetar dimovpetar requested a review from a team September 4, 2023 11:47
LidiyaGeorgieva
LidiyaGeorgieva requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only two remarks:

  • images should be top aligned, not vertically centered
  • when there is only one button -"X" it shouldn't have margin to the left
    image

@dimovpetar
Copy link
Contributor Author

Looks good. Only two remarks:

  • images should be top aligned, not vertically centered
  • when there is only one button -"X" it shouldn't have margin to the left
    image

@dimovpetar dimovpetar merged commit 6594cd5 into main Sep 13, 2023
@dimovpetar dimovpetar deleted the uploadcollectionitem_buttons_wrapping branch September 13, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimovpetar @LidiyaGeorgieva