fix(ui5-datepicker): display extreme values correctly #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
a-z-ivanov
force-pushed
the
datepicker-fix-extreme-values
branch
from
d368fc9 to
7b1271b
Compare
ilhan007
reviewed
Feb 22, 2019
packages/main/src/Calendar.js
Outdated
| }); | ||
|
|
||
| this._isShiftingYears = true; | ||
| } | ||
|
|
||
| _showPrevPageYears() { | ||
| if (this._yearPicker.timestamp) { |
There was a problem hiding this comment.
These blocks (the one highlighted here) and above seem very similar, perhaps you can extract and reuse code.
ilhan007
reviewed
Feb 22, 2019
| if (this._calendarDate.getYear() < 1) { | ||
| // 0 is a valid year, but we cannot display it | ||
| return; | ||
| } |
There was a problem hiding this comment.
discussed, as 0 is valid lets display it.
There was a problem hiding this comment.
there is a problem in islamic. 1 is the minimum for now
ilhan007
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist