-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-badge): add different design types #7564
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
372ac20
feat(ui5-badge): add different design types
TeodorTaushanov 11f6a03
feat(ui5-badge): fix lint errors
TeodorTaushanov 5229942
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 8d72e9c
feat(ui5-badge): fix lint errors
TeodorTaushanov 79bcff8
feat(ui5-badge): fix typo
TeodorTaushanov a616b57
feat(ui5-badge): rename enums and properties
TeodorTaushanov ae3c053
feat(ui5-badge): rename enums and properties
TeodorTaushanov 1a9ae93
feat(ui5-badge): rename enums and properties
TeodorTaushanov 2e9ae0e
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 11f538d
feat(ui5-badge): improve example
TeodorTaushanov 33e06b9
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 9ed9478
feat(ui5-badge): add "click" event
TeodorTaushanov 847687e
feat(ui5-badge): value state desing types
TeodorTaushanov 269d91c
feat(ui5-badge): add different design types
TeodorTaushanov ab45cd5
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov a8e4853
feat(ui5-badge): add default state icon
TeodorTaushanov bde4f8d
feat(ui5-badge): fix lint errors
TeodorTaushanov 94bc65f
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 1e72921
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 70f52a7
feat(ui5-badge): add samples with only styles
TeodorTaushanov 018a351
feat(ui5-badge): improve styling
TeodorTaushanov 6666e96
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 9799f66
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov b12f75b
refactor(ui5-badge): change properties
TeodorTaushanov 0ff75fd
refactor(ui5-badge): fix button-like styles
TeodorTaushanov 1e56f76
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov d599679
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov ce3f7e3
fix(ui5-badge): test wrapping mode
TeodorTaushanov c94fc0e
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 3f9b174
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov d39c743
fix(ui5-badge): add wrapping mode
TeodorTaushanov 17dab20
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 6e0795e
fix(ui5-badge): use flex layout
TeodorTaushanov c600de7
fix(ui5-badge): tag styles
TeodorTaushanov ecc2c03
fix(ui5-badge): fix shadows
TeodorTaushanov 50dc0b2
fix(ui5-badge): improve styles
TeodorTaushanov fd49d0b
fix(ui5-badge): add tests
TeodorTaushanov cb97ba1
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 070fbe1
fix(ui5-badge): improve documentation
TeodorTaushanov 24685d7
fix(ui5-badge): improve documentation
TeodorTaushanov 0ad1767
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 15f010c
fix(ui5-badge): improve documentation
TeodorTaushanov a4b5180
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov a6d2b16
fix(ui5-badge): fix accessibility
TeodorTaushanov e166b3c
fix(ui5-badge): add samples
TeodorTaushanov b796426
fix(ui5-badge): add tests
TeodorTaushanov 06b9654
fix(ui5-badge): fix typo
TeodorTaushanov e03b8a5
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 4c4cf17
fix(ui5-badge): improve test page
TeodorTaushanov 6709e57
fix(ui5-badge): hc themes
TeodorTaushanov b112aed
fix(ui5-badge): styles
TeodorTaushanov ce01e1a
Merge remote-tracking branch 'origin' into badge_interactive
TeodorTaushanov 045e025
fix(ui5-badge): fix comments
TeodorTaushanov 816888f
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 2a5d378
fix(ui5-badge): add more descriptions for design types
TeodorTaushanov 11b28a8
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 60a022d
fix(ui5-badge): fix comments
TeodorTaushanov 4b94c75
Merge remote-tracking branch 'origin/main' into badge_interactive
TeodorTaushanov 778b4cd
fix(ui5-badge): fix css styles
TeodorTaushanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,30 @@ | ||
<div class="ui5-badge-root"> | ||
<slot name="icon"></slot> | ||
{{#if interactive}} | ||
<button class="ui5-badge-root" | ||
title="{{_title}}" | ||
aria-roledescription="{{_roleDescription}}" | ||
aria-description="{{_valueState}}" | ||
@onclick={{_onclick}} | ||
> | ||
{{> content}} | ||
</button> | ||
{{else}} | ||
<div class="ui5-badge-root" | ||
title="{{_title}}"> | ||
{{> content}} | ||
</div> | ||
{{/if}} | ||
|
||
{{#*inline "content"}} | ||
<slot name="icon"></slot> | ||
{{#if this._semanticIconName}} | ||
<ui5-icon class="ui5-badge-semantic-icon" name="{{_semanticIconName}}"></ui5-icon> | ||
{{/if}} | ||
<span class="ui5-hidden-text">{{badgeDescription}}</span> | ||
{{#if hasText}} | ||
<label class="ui5-badge-text"><bdi><slot></slot></bdi></label> | ||
<span class="ui5-badge-text"><bdi><slot></slot></bdi></span> | ||
{{/if}} | ||
{{/inline}} | ||
|
||
|
||
|
||
|
||
<span class="ui5-hidden-text">{{badgeDescription}}</span> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum?