Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-label): use correct i18n bundle & make component language aware #7652

Merged
merged 1 commit into from
Oct 2, 2023
Merged

fix(ui5-label): use correct i18n bundle & make component language aware #7652

merged 1 commit into from
Oct 2, 2023

Conversation

Lukas742
Copy link
Collaborator

@Lukas742 Lukas742 commented Oct 2, 2023

No description provided.

nnaydenow
nnaydenow approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmkv tagging you just fyi

@georgimkv georgimkv merged commit 7b43587 into main Oct 2, 2023
7 checks passed
@georgimkv georgimkv deleted the fix/label-i18n-bundle branch October 2, 2023 14:53
vladitasev pushed a commit that referenced this pull request Oct 13, 2023
@Lukas742 @vladitasev
fix(ui5-label): use correct i18n bundle & make component language awa…
14a4938 
…re (#7652)
@0anton
Copy link

0anton commented Nov 20, 2023

Which release this fix managed to get in?
It is anounced for v1.18.1-rc.0 pre-release but not mentioned in release v1.19.0.
We are facing performance problems in the app due to 1000 warnings about labels missing i18n table.

@Lukas742
Copy link
Collaborator Author

Hi @0anton

this was also fixed in v1.19.0 even though it doesn't show up in the release log for that version.
@ilhan007 do you know why this change was omitted in the release log?

@ilhan007
Copy link
Member

Hi @Lukas742 an issue with the change log generation process, sorry for the confusion @0anton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lukas742 @0anton @ilhan007 @nnaydenow @georgimkv