Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): fix font72 for special characters #7949

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Dec 2, 2023

Fixes the appearance of special characters by adding unicode-range to extend the range of characters of our font family.
The PR follows the used unicode-ranges in SAPUI5 see the following change from Jun 2023

Fixes: #7948

Before (see the first and the last characters)
Screenshot 2023-12-02 at 19 22 44

After
Screenshot 2023-12-02 at 19 21 53

Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to do the overrides only for the smaller font families, because full font families already have Unicode solution.

@ilhan007 ilhan007 merged commit 55665b0 into main Dec 4, 2023
6 checks passed
@ilhan007 ilhan007 deleted the fix-font-special-chars branch December 4, 2023 10:09
ilhan007 added a commit that referenced this pull request Dec 9, 2023
Fixes the appearance of special characters by adding unicode-range to extend the range of characters of our font family.
The PR follows the used unicode-ranges in SAPUI5 see the following change from Jun 2023

Fixes: #7948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants