fix(ui5-menu): improve focus handling #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHristov-sap
approved these changes
Feb 28, 2024
unazko
changed the title
vladitasev
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Let's start with the event as private, and if the stakeholders can make their story work and stick with this solution, then we'll document it in the next patch.
Question: what is the best name for the event? ui5-item-focusin or just ui5-item-focus? For me, if there is no peir focusin/focusout, then focus would be best. Correct me if I'm missing some detail here
vladitasev
reviewed
Feb 28, 2024
vladitasev
requested changes
Feb 28, 2024
vladitasev
approved these changes
Feb 28, 2024
tsanislavgatev
approved these changes
Feb 28, 2024
nnaydenow
pushed a commit
that referenced
this pull request
Mar 20, 2024
fix(ui5-menu): dispatch internal focus in event - We no longer count on the ui5-responsive popover to retrieve the focus over ui5-menu-item opener on ui5-menu close. - There is a differentiation between mouse and keyboard interactions aimed to retrieve the focus to the opener element on ui5-menu close.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer count on the
ui5-responsive popoverto retrievethe focus over
ui5-menu-itemopener onui5-menuclose.There is a differentiation between mouse and keyboard interactions
aimed to retrieve the focus to the opener element on
ui5-menuclose.