Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-textarea): fix negative textarea growing #8883

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 30, 2024

FIXES: #8767

@MapTo0 MapTo0 requested review from ndeshev and niyap April 30, 2024 13:07
niyap
niyap previously requested changes May 7, 2024
packages/main/src/themes/TextArea.css Show resolved Hide resolved
@github-actions github-actions bot added the Stale label May 29, 2024
@github-actions github-actions bot closed this Jun 6, 2024
@MapTo0 MapTo0 reopened this Jun 20, 2024
@MapTo0 MapTo0 requested a review from niyap June 20, 2024 14:32
@github-actions github-actions bot removed the Stale label Jun 21, 2024
@github-actions github-actions bot added the Stale label Jul 12, 2024
@github-actions github-actions bot closed this Jul 19, 2024
@MapTo0 MapTo0 reopened this Jul 29, 2024
@nikoletavnv nikoletavnv self-requested a review July 29, 2024 14:02
@github-actions github-actions bot removed the Stale label Jul 30, 2024
@MapTo0 MapTo0 dismissed niyap’s stale review July 31, 2024 11:57

Niya is off :/

@MapTo0 MapTo0 closed this Jul 31, 2024
@MapTo0 MapTo0 reopened this Jul 31, 2024
@MapTo0 MapTo0 removed request for ndeshev and niyap July 31, 2024 13:06
@MapTo0 MapTo0 merged commit db67090 into main Jul 31, 2024
17 of 18 checks passed
@MapTo0 MapTo0 deleted the te-error-growing branch July 31, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SF][A11y][ui5-textarea]: growingMaxLines does not work when valueState is Error
3 participants