Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-button): adjust screen reader announcement order #8997

Merged
merged 5 commits into from
Jun 5, 2024
Merged

fix(ui5-button): adjust screen reader announcement order #8997

merged 5 commits into from
Jun 5, 2024

Conversation

unazko
Copy link
Contributor

@unazko unazko commented May 18, 2024

Fixes: #8976

@unazko unazko requested a review from elenastoyanovaa May 19, 2024 07:11
elenastoyanovaa
elenastoyanovaa previously requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title

packages/main/test/specs/Button.spec.js Outdated Show resolved Hide resolved
packages/main/src/Button.hbs Outdated Show resolved Hide resolved
@unazko unazko changed the title Button announcement order fix(ui5-button): adjust screen reader announcement order May 20, 2024
elenastoyanovaa
elenastoyanovaa reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@elenastoyanovaa elenastoyanovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure aria-describedby is not rendered when a button has no type. Other than that I approve the change from ACC point of view. Should be reviewed from your team members as well.

@unazko unazko requested a review from elenastoyanovaa June 5, 2024 07:48
@unazko unazko marked this pull request as ready for review June 5, 2024 08:59
@unazko unazko requested a review from vladitasev June 5, 2024 09:16
@tsanislavgatev tsanislavgatev dismissed elenastoyanovaa’s stale review June 5, 2024 10:45

The PR title is updated and the property is conditional.

@unazko unazko merged commit 2d9a16b into SAP:main Jun 5, 2024
10 checks passed
unazko added a commit to unazko/ui5-webcomponents that referenced this pull request Jun 5, 2024
@unazko
fix(ui5-button): adjust screen reader announcement order (SAP#8997)
0cd7335 
Fixes: SAP#8976
ilhan007 pushed a commit that referenced this pull request Jun 18, 2024
@unazko
fix(ui5-button): adjust screen reader announcement order (#8997) (#9127)
bfa1269 
Fixes: #8976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsanislavgatev tsanislavgatev tsanislavgatev approved these changes

@elenastoyanovaa elenastoyanovaa Awaiting requested review from elenastoyanovaa

@vladitasev vladitasev Awaiting requested review from vladitasev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACC: wrong order of texts in accessibility reader on a button
3 participants
@unazko @tsanislavgatev @elenastoyanovaa