Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown slots no longer cause an error #90

Merged
merged 3 commits into from
Feb 26, 2019
Merged

fix: unknown slots no longer cause an error #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
935796c
fix: unknown slots no longer cause an error
vladitasev Feb 25, 2019
ed69486
bypass eslint for console
vladitasev Feb 25, 2019
89a5312
fix eslint, give more info
vladitasev Feb 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/base/src/sap/ui/webcomponents/base/WebComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ class WebComponent extends HTMLElement {
const autoIncrementMap = new Map();
domChildren.forEach(child => {
const slot = child.getAttribute("data-ui5-slot") || this.constructor.getMetadata().getDefaultSlot();
if (slotsMap[slot] === "undefined") {
if (slotsMap[slot] === undefined) {
const validValues = Object.keys(slotsMap).join(", ");
console.warn(`Unknown data-ui5-slot value: ${slot}, ignoring`, child, `Valid data-ui5-slot values are: ${validValues}`); // eslint-disable-line
return;
}
let slotName;
Expand Down