Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tabcontainer): fix selected sub items screen readers announcement #9426

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Jul 9, 2024

Selected sub item was read as “not selected” by screen readers.

@TeodorTaushanov TeodorTaushanov requested review from BorisDafov and a team July 10, 2024 09:56
@BorisDafov
Copy link

I suggest to change the commit message to:
Selected sub items are now correctly announced by screen readers.

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-tabcontainer): fix sub items selection fix(ui5-tabcontainer): fix selected sub items screen readers announcement Jul 10, 2024
@TeodorTaushanov
Copy link
Member Author

I suggest to change the commit message to: Selected sub items are now correctly announced by screen readers.

Changed to "fix selected sub items screen readers announcement"

@BorisDafov
Copy link

I approve the PR from UA perspective

@TeodorTaushanov TeodorTaushanov merged commit fae1a3a into main Jul 11, 2024
10 checks passed
@TeodorTaushanov TeodorTaushanov deleted the tc_subtab_selection branch July 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants