Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-combobox): correct valueStateMessage documentation #9458

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix(ui5-combobox): correct valueStateMessage documentation #9458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da6561
fix(ui5-combobox): correct valueStateMessage documentation
ivoplashkov Jul 11, 2024
4ff3ae2
fix(ui5-combobox): apply feedback
ivoplashkov Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/ComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ class ComboBox extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the `ui5-combobox` is in `Information`, `Warning` or `Error` value state.
* when the `ui5-combobox` is in `Information`, `Critical` or `Negative` value state.
ivoplashkov marked this conversation as resolved.
Show resolved Hide resolved
* @since 1.0.0-rc.9
* @public
*/
ivoplashkov marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/DatePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
* @since 1.0.0-rc.7
* @public
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/FileUploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ class FileUploader extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
* @since 1.0.0-rc.9
* @public
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/Input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ type InputSuggestionScrollEventDetail = {
*
* The text field can be editable or read-only (`readonly` property),
* and it can be enabled or disabled (`disabled` property).
* To visualize semantic states, such as "error" or "warning", the `valueState` property is provided.
* To visualize semantic states, such as "Negative" or "Critical", the `valueState` property is provided.
* When the user makes changes to the text, the change event is fired,
* which enables you to react on any text change.
*
Expand Down Expand Up @@ -530,7 +530,7 @@ class Input extends UI5Element implements SuggestionComponent, IFormInputElement
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
*
* **Note:** If the component has `suggestionItems`,
* the `valueStateMessage` would be displayed as part of the same popover, if used on desktop, or dialog - on phone.
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/MultiComboBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ class MultiComboBox extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
* @since 1.0.0-rc.9
* @public
*/
Expand Down
1 change: 1 addition & 0 deletions packages/main/src/RatingIndicator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ class RatingIndicator extends UI5Element {

_onkeydown(e: KeyboardEvent) {
if (this.disabled || this.readonly) {
e.preventDefault();
return;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/Select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class Select extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
*
* **Note:** If the component has `suggestionItems`,
* the `valueStateMessage` would be displayed as part of the same popover, if used on desktop, or dialog - on phone.
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/StepInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class StepInput extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the component is in `Information`, `Warning` or `Error` value state.
* when the component is in `Information`, `Critical` or `Negative` value state.
* @public
*/
@slot()
Expand Down
4 changes: 2 additions & 2 deletions packages/main/src/TextArea.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ class TextArea extends UI5Element implements IFormInputElement {
* Defines the value state of the component.
*
* **Note:** If `maxlength` property is set,
* the component turns into "Warning" state once the characters exceeds the limit.
* In this case, only the "Error" state is considered and can be applied.
* the component turns into "Critical" state once the characters exceeds the limit.
* In this case, only the "Negative" state is considered and can be applied.
* @default "None"
* @since 1.0.0-rc.7
* @public
Expand Down
2 changes: 1 addition & 1 deletion packages/main/src/TimePicker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ class TimePicker extends UI5Element implements IFormInputElement {
* **Note:** If not specified, a default text (in the respective language) will be displayed.
*
* **Note:** The `valueStateMessage` would be displayed,
* when the `ui5-time-picker` is in `Information`, `Warning` or `Error` value state.
* when the `ui5-time-picker` is in `Information`, `Critical` or `Negative` value state.
* @since 1.0.0-rc.8
* @public
*/
Expand Down