Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input, ui5-multi-input): fix issues in inputs test pages #9506

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(ui5-input, ui5-multi-input): fix issues in inputs test pages #9506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions packages/main/test/pages/Input.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,6 @@ <h3>Input with disabled autocomplete (type-ahead)</h3>
<ui5-suggestion-item text="Condensed"></ui5-suggestion-item>
</ui5-input>

<h3>Input with disabled autocomplete and preventable suggestion select</h3>
<ui5-input id="input-prevent-suggestion-select" show-suggestions no-typeahead="true">
<ui5-suggestion-item text="Cozy"></ui5-suggestion-item>
<ui5-suggestion-item text="Compact"></ui5-suggestion-item>
<ui5-suggestion-item text="Condensed"></ui5-suggestion-item>
</ui5-input>

<h3> 'change' event result</h3>
<ui5-input id="inputResult"></ui5-input>

Expand Down Expand Up @@ -345,7 +338,7 @@ <h3>Input suggestions with highlighing and XSS test</h3>

<h3>Test width of suggestions popover</h3>
<ui5-input id="suggestionsPopoverWidth" show-suggestions class="input6auto">
<ui5-suggestion-item>Argentinaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ui5-suggestion-item>
<ui5-suggestion-item text="Argentinaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"></ui5-suggestion-item>
</ui5-input>

<h3>Input in a Dialog</h3>
Expand All @@ -365,9 +358,9 @@ <h3>Short Input With Centered Text</h3>

<h3>Input with suggestions: clear value on selection change</h3>
<ui5-input id="change-event-value" show-suggestions>
<ui5-suggestion-item>Cozy</ui5-suggestion-item>
<ui5-suggestion-item>Compact</ui5-suggestion-item>
<ui5-suggestion-item>Condensed</ui5-suggestion-item>
<ui5-suggestion-item text="Cozy"></ui5-suggestion-item>
<ui5-suggestion-item text="Compact"></ui5-suggestion-item>
<ui5-suggestion-item text="Condensed"></ui5-suggestion-item>
</ui5-input>
<link rel="stylesheet" type="text/css" href="./styles/Input.css">

Expand Down Expand Up @@ -697,7 +690,7 @@ <h3>Input - open suggestions picker</h3>
labelInputChange.innerHTML = "Event [input] :: " + value;
};


const suggestCustom = e => {
let input = e.target;
let value = input.value;
Expand Down Expand Up @@ -1019,15 +1012,15 @@ <h3>Input - open suggestions picker</h3>
data.forEach((country) => {
const item = document.createElement("ui5-suggestion-item-custom");
item.setAttribute("text", country);

item.innerHTML = `
<div class='item-content'>
<ui5-icon name="globe"></ui5-icon>
<div class='item-titles'>
<span>${generateHighlightedMarkup(country, value)}</span>
<small>EU</small>
</div>

<span class='green'><b>EU</b></span>
</div>
`
Expand Down
2 changes: 1 addition & 1 deletion packages/main/test/pages/Input_quickview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ <h1> Test Quick View sample</h1>

[].slice.call(document.querySelectorAll("#inputPreview2 .suggestionItem")).forEach(function(el) {
el.addEventListener("mouseover", function (event) {
const item = event.detail.item;
const item = event.currentTarget;
quickViewCard2.open = false;
quickViewCard2.opener = item;
quickViewCard2.open = true;
Expand Down
14 changes: 7 additions & 7 deletions packages/main/test/pages/InputsLazyLoading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ <h1>Preload items</h1>
<h1>Hardcoded items</h1>

<ui5-input show-suggestions>
<ui5-suggestion-item>Dryanovo</ui5-suggestion-item>
<ui5-suggestion-item>Gabrovo</ui5-suggestion-item>
<ui5-suggestion-item>Sofia</ui5-suggestion-item>
<ui5-suggestion-item>Yablanitsa</ui5-suggestion-item>
<ui5-suggestion-item>New York</ui5-suggestion-item>
<ui5-suggestion-item text="Dryanovo"></ui5-suggestion-item>
<ui5-suggestion-item text="Gabrovo"></ui5-suggestion-item>
<ui5-suggestion-item text="Sofia"></ui5-suggestion-item>
<ui5-suggestion-item text="Yablanitsa"></ui5-suggestion-item>
<ui5-suggestion-item text="New York"></ui5-suggestion-item>
</ui5-input>
</div>

Expand Down Expand Up @@ -204,8 +204,8 @@ <h1>Hardcoded items</h1>

const addSuggestions = (arr) => {
arr.forEach((item, i) => {
const el = document.createElement("ui5-input-suggestion");
el.innerText = `${item} ${i}`;
const el = document.createElement("ui5-suggestion-item");
el.setAttribute("text", `${item} ${i}`);
field.appendChild(el);
});
};
Expand Down
2 changes: 1 addition & 1 deletion packages/main/test/pages/MultiInput.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ <h1 class="sample-container-title">Custom Suggestions</h1>
}
document.getElementById("mi-event").addEventListener("ui5-token-delete", handleTokenDelete2);

document.getElementById("token-unique").addEventListener("ui5-paste", function (event) {
document.getElementById("token-unique").addEventListener("paste", function (event) {
event.preventDefault();

let pastedText = (event.clipboardData || window.clipboardData).getData('text/plain');;
Expand Down