Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-list): improved loading state #9520

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

plamenivanov91
Copy link
Contributor

Loading state wasn't displayed properly.
This change adapts the list to the busy indicator and fixes the issue.

Fixes: #9476

Loading state wasn't displayed properly.
This change adapts the list to the busy indicator and fixes the issue.

Fixes: SAP#9476
@dobrinyonkov dobrinyonkov self-requested a review July 19, 2024 07:40
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you make the busy indicator focusable, you will notice that the focus outline is rounded, while the background is rectangular. Just pull the main branch - this issue is already fixed.

packages/main/src/List.hbs Outdated Show resolved Hide resolved
@plamenivanov91 plamenivanov91 merged commit b32adf5 into SAP:main Jul 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[List]: Busy state is not displayed properly
3 participants