Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enableDefaultTooltips config option #9559

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jul 25, 2024

This configuration option controls whether components will display default tooltips in specific cases.

Default tooltips are generally recommended to cover accessibility standards and typically you would not need to modify this setting.
However, in rare cases you may want to implement custom tooltip visualization and turn off the default tooltips.
To do so, set enableDefaultTooltips to false.

Example:

<script data-ui5-config type="application/json">
{
	"enableDefaultTooltips": false
}
</script>
import { getEnableDefaultTooltips, setEnableDefaultTooltips } from "@ui5/webcomponents-base/dist/config/Tooltips.js";
setEnableDefaultTooltips(false);

Fixes: #9494

@ilhan007 ilhan007 requested review from nnaydenow and pskelin July 29, 2024 17:53
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO should be called enableDefaultTooltips, getEnableDefaultTooltips

@ilhan007 ilhan007 changed the title feat: add defaultTooltips config option feat: add enableDefaultTooltips config option Aug 5, 2024
@ilhan007 ilhan007 requested a review from vladitasev August 5, 2024 08:34
@ilhan007 ilhan007 merged commit a672788 into main Aug 6, 2024
10 checks passed
@ilhan007 ilhan007 deleted the feat-tooltip-config branch August 6, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Possibility to turn off HTML tooltip
2 participants