Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add loginNetWeaver function #104

Merged
merged 8 commits into from
Jan 20, 2023
Merged

add loginNetWeaver function #104

merged 8 commits into from
Jan 20, 2023

Conversation

Templada
Copy link
Contributor

No description provided.

@Templada Templada requested a review from DIFSRIP January 10, 2023 16:37
DIFSRIP
DIFSRIP reviewed Jan 11, 2023
View reviewed changes
Copy link
Collaborator

@DIFSRIP DIFSRIP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, maybe we can ad a short test for it. Just for local execution and / or a static one as for the others.

src/reuse/modules/ui5/session.ts Outdated Show resolved Hide resolved
@Templada
Copy link
Contributor Author

looks good to me, maybe we can ad a short test for it. Just for local execution and / or a static one as for the others.

fine with me, then i just move the loginNetWeaver to common and create a new session module

@Templada Templada marked this pull request as ready for review January 20, 2023 13:23
@DIFSRIP DIFSRIP merged commit f3cdc7e into main Jan 20, 2023
@DIFSRIP DIFSRIP deleted the loginNetWeaver branch January 20, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DIFSRIP DIFSRIP DIFSRIP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Templada @DIFSRIP