Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webdriverio v8 #116

Merged
merged 19 commits into from
Apr 5, 2023
Merged

Webdriverio v8 #116

merged 19 commits into from
Apr 5, 2023

Conversation

Varun-Hegde
Copy link
Contributor

@Varun-Hegde Varun-Hegde commented Feb 19, 2023

Summary of the changes done

  • Updated wdio versions in package.json. Added type definitions for fs-extra
  • recursive property not available in fse.copy(). It does a recursive copy by default.
  • store the config in shared-storage-service. Retrieve and have added it as a property to browser object, since config property is no more available in wdio-v8.
  • Added the "shared-store" service in the services property of base.conf.js. (Need to include this in qmate-profiles repo as well)
  • wdio's addValue/setValue accept number/string as their parameters. So have refactored the reuse APIs using them and also adjusted the tests related to them (at places where we are passing an empty/undefined value to the api)
  • wdio v8 introduced a new action interface. So have updated the nonUi5.userInteraction.dragAndDrop() reuse api.

@Varun-Hegde Varun-Hegde requested a review from DIFSRIP February 20, 2023 07:15
Copy link
Collaborator

@DIFSRIP DIFSRIP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just indentation can be fixed with prettier for vscode.

src/reuse/modules/nonUi5/userInteraction.ts Outdated Show resolved Hide resolved
src/reuse/modules/ui5/userInteraction.ts Outdated Show resolved Hide resolved
@Varun-Hegde Varun-Hegde requested a review from DIFSRIP February 20, 2023 18:17
package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@DIFSRIP DIFSRIP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DIFSRIP DIFSRIP merged commit 4e037c5 into main Apr 5, 2023
@DIFSRIP DIFSRIP deleted the webdriverio-v8 branch April 5, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants