Feature/fix sort #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SARDONYX-sard
added
enhancement
At this point, perhaps the array writing could still be wrong. (The binary data in `skeleton.hkx` is not reproducible yet.)
GPL tainted because `rhexdump` crate was GPL. Next, license check and dependency check by `cargo-deny` are performed to repel GPL. The last commit eliminates all GPL dependencies. But since the git object contains the GPL, we rewrite the history completely after eliminating the GPL code at the end of this, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dependencies, license(GPL violation) & remove GPL crate
GPL tainted because
rhexdumpcrate was GPL.Next, license check and dependency check by
cargo-denyare performed to remove GPL crates.The last commit eliminates all GPL dependencies.
But since the git object contains the GPL, we rewrite the history completely after eliminating the GPL code at the end of this, just in case.