Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update COG category mapping #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update COG category mapping #108

wants to merge 1 commit into from

Conversation

siddC
Copy link
Collaborator

@siddC siddC commented Mar 9, 2022

Update COG mapping. We originally used X for genes with no COG category but that is unfortunately incorrect (see https://www.ncbi.nlm.nih.gov/research/cog/cogcategory/X/#). X is actually a COG category which deals with the mobilome (prophages, transposons, and the like).

I've updated the cog_dict in gene_util to reflect this, and added - to represent genes with no COG annotation

@siddC siddC requested a review from avsastry March 9, 2022 04:27
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #108 (1c57c39) into master (77537f6) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   54.23%   54.23%           
=======================================
  Files          17       17           
  Lines        3321     3321           
  Branches      642      643    +1     
=======================================
  Hits         1801     1801           
  Misses       1395     1395           
  Partials      125      125           
Impacted Files Coverage Δ
src/pymodulon/gene_util.py 0.00% <ø> (ø)
src/pymodulon/core.py 74.80% <50.00%> (ø)
src/pymodulon/plotting.py 87.01% <100.00%> (ø)
src/pymodulon/util.py 69.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c333004...1c57c39. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant