Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Remove async message feature #1322

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

SBoudrias
Copy link
Owner

Planning to remove built-in support for async/functions message.

The reasons are kinda simple:

  1. I don't want to new Inquirer to be a state/flow management library (that's better done elsewhere; usually with simple Node/JS built-in)
  2. The UX is bad; and not been a priority to handle due to point 1
  3. When starting the rewrite, I had a few more wrapped logic there, but it was slowly all removed to be inside each prompts. So only message is left, and shows how it didn't match the design goals of the new API.

Do let me know if you think otherwise. I'll leave this PR open for now and bundle with some other breaking changes.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2257e58) 94.48% compared to head (b0c122e) 94.44%.
Report is 1 commits behind head on release-v2.

Files Patch % Lines
packages/editor/src/index.mts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           release-v2    #1322      +/-   ##
==============================================
- Coverage       94.48%   94.44%   -0.04%     
==============================================
  Files              51       51              
  Lines            4457     4426      -31     
  Branches          776      772       -4     
==============================================
- Hits             4211     4180      -31     
  Misses            241      241              
  Partials            5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias SBoudrias force-pushed the deprecate/async-messages branch from 9273ae5 to b0c122e Compare January 27, 2024 19:43
@SBoudrias SBoudrias changed the base branch from master to release-v2 January 27, 2024 19:47
@SBoudrias SBoudrias merged commit 3559d03 into release-v2 Jan 27, 2024
18 of 20 checks passed
@SBoudrias SBoudrias deleted the deprecate/async-messages branch January 27, 2024 19:48
SBoudrias added a commit that referenced this pull request Feb 4, 2024
* Breaking: Remove async message feature (#1322)

* BREAKING: Require Node >=18

* [major] Introduce theming capacities (#1323)

* Chore: Refactor usePrefix to rely on a new Theme construct

* Feat: Apply theming to all prompts

* Chore: Bump dependencies

* Fix: tsconfig.json formatting inconsistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant