Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to individual lodash packages or standard JS #1440

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jun 25, 2024

Moves to using individual lodash imports to reduce package size.

Moves to using individual lodash imports to reduce package size.
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@290bf73). Learn more about missing BASE report.

Files Patch % Lines
packages/inquirer/lib/objects/choices.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage        ?   96.77%           
=======================================
  Files           ?       54           
  Lines           ?     5031           
  Branches        ?      835           
=======================================
  Hits            ?     4869           
  Misses          ?      154           
  Partials        ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias SBoudrias changed the title feat: move to individual lodash packages feat: move to individual lodash packages or standard JS Jun 26, 2024
@SBoudrias SBoudrias merged commit 6b307b9 into SBoudrias:main Jun 26, 2024
8 checks passed
@43081j
Copy link
Contributor Author

43081j commented Jun 26, 2024

@SBoudrias good work figuring out how to strip a few more of them away 🥳

really good progress in terms of making it leaner and more maintainable 🙏

@43081j 43081j deleted the lodashless branch June 26, 2024 22:35
@SBoudrias
Copy link
Owner

Thanks for kicking this off!

@DJDodds
Copy link

DJDodds commented Jun 27, 2024

GHSA-p6mc-m468-83gw
Using the lodash.set package has picked up an auditing issue. Is there some workaround for this ?

@SBoudrias
Copy link
Owner

See #1443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants