Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inquirer): export types Question, DistinctQuestion and Answers #1559

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

mshima
Copy link
Contributor

@mshima mshima commented Sep 18, 2024

Related to #1527.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@bd45397). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1559   +/-   ##
=======================================
  Coverage        ?   98.03%           
=======================================
  Files           ?       39           
  Lines           ?     2389           
  Branches        ?      644           
=======================================
  Hits            ?     2342           
  Misses          ?       40           
  Partials        ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias SBoudrias changed the title feat: export Question and Answers feat(inquirer): export types Question, DistinctQuestion and Answers Sep 27, 2024
@SBoudrias SBoudrias merged commit 66a675e into SBoudrias:main Sep 27, 2024
10 checks passed
@SBoudrias
Copy link
Owner

Implemented a few basic changes:

  1. Rename types to Question/DistinctQuestion to match those in @type/inquirer.
  2. Remove test examples of PromptSession - I updated the test with [] const satisfies Question[] which achieve the same thing without needing to know about another type. I kept the export as I assumed you'll need it for Yeoman.

inquirer@11.1.0 includes this.

@mshima mshima deleted the export-types branch September 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants