Revert tty behavior for inquirer 7.x

[mshima]

• Move tty check to setupReadlineOptions
• Add skipTTYChecks
• Enable skipTTYChecks by default for 7.x behavior stability.

Fixes #902.

[codecov]

Codecov Report

Merging #903 into master will decrease coverage by 0.26%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
- Coverage   93.53%   93.27%   -0.27%     
==========================================
  Files          26       26              
  Lines        1068     1071       +3     
  Branches       23       23              
==========================================
  Hits          999      999              
- Misses         69       72       +3

Impacted Files	Coverage Δ
packages/inquirer/lib/ui/prompt.js	100% <ø> (ø)	⬆️
packages/inquirer/lib/ui/baseUI.js	90.9% <100%> (-9.1%)	⬇️
packages/inquirer/lib/inquirer.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c521b7...3b86d23. Read the comment docs.

[ruyadorno]

I would love if you could port the test that uses a valid manually-opened tty from #898 into this - ensuring there's no regressions even if folks were to use skipTTYChecks: false:

    it('No exception when using tty other than process.stdin', function() {
      // Manually opens a new tty
      var input = new tty.ReadStream(fs.openSync('/dev/tty', 'r+'));

      // Uses manually opened tty as input instead of process.stdin
      var prompt = inquirer.createPromptModule({
        input: input,
        skipTTYChecks: false
      });

      var prompts = [
        {
          type: 'input',
          name: 'q1',
          default: 'foo',
          message: 'message'
        }
      ];

      var promise = prompt(prompts);
      promise.ui.rl.emit('line');

      // Release the input tty socket
      input.unref();

      return promise.then(answers => {
        expect(answers).to.deep.equal({ q1: 'foo' });
      });
    });

it will also help with getting a higher coverage

[ruyadorno]

@mshima properly sent you the test here: mshima#1

[SBoudrias]

Thanks to both of you for the help on this issue :D

[SBoudrias]

7.0.7 is out now.