Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove windows workaround and add known issues to README. #904

Merged
merged 1 commit into from
Mar 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .project
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<projectDescription>
<name>Inquirer.js</name>
<comment></comment>
<projects>
</projects>
<buildSpec>
</buildSpec>
<natures>
</natures>
</projectDescription>
11 changes: 10 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ A collection of common interactive command line user interfaces.
2. [User Interfaces and Layouts](#layouts)
1. [Reactive Interface](#reactive)
3. [Support](#support)
4. [Known issues](#issues)
4. [News](#news)
5. [Contributing](#contributing)
6. [License](#license)
Expand Down Expand Up @@ -357,7 +358,7 @@ look at issues found on other command line - feel free to report any!
- **Mac OS**:
- Terminal.app
- iTerm
- **Windows**:
- **Windows ([Known issues](#issues))**:
- [ConEmu](https://conemu.github.io/)
- cmd.exe
- Powershell
Expand All @@ -366,6 +367,14 @@ look at issues found on other command line - feel free to report any!
- gnome-terminal (Terminal GNOME)
- konsole

## Know issues

<a name="issues"></a>

Running Inquirer together with network streams in Windows platform inside some terminals can result in process hang.
Workaround: run inside another terminal.
Please refer to the https://github.com/nodejs/node/issues/21771

## News on the march (Release notes)

<a name="news"></a>
Expand Down
6 changes: 1 addition & 5 deletions packages/inquirer/lib/ui/baseUI.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,7 @@ class UI {
// Close the readline
this.rl.output.end();
this.rl.pause();

// @see https://github.com/nodejs/node/issues/21771
if (!/^win/i.test(process.platform)) {
this.rl.close();
}
this.rl.close();
}
}

Expand Down