Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split system messages to separated JSON files #86

Open
winstonsung opened this issue Jul 4, 2024 · 2 comments
Open

Split system messages to separated JSON files #86

winstonsung opened this issue Jul 4, 2024 · 2 comments
Assignees
@winstonsung
Labels
enhancement New feature or request

Comments

@winstonsung
Copy link
Collaborator

winstonsung commented Jul 4, 2024 •
edited
Loading

(as title described)

Reason: Prevent hardcoded strings.

See https://github.com/wikimedia/mediawiki/blob/38066e5/languages/i18n/preferences/zh-hant.json
@winstonsung winstonsung added the enhancement New feature or request label Jul 4, 2024
@iach526526
Copy link
Member

Do you mean the bot's reply strings should be written in a separate JSON file?

winstonsung added a commit that referenced this issue Aug 13, 2024
@winstonsung
Packaging: Prepare src layout migration
2c26b4d 
- Add i18n/*
- Add stats/
- Remove mis-added config/cog/

Bug: #86
Change-Id: I9021527ed5b5cbb7109684ef8f086afccef631ac
winstonsung added a commit that referenced this issue Aug 13, 2024
@winstonsung
Packaging: Prepare src layout migration
057d467 
- Add system_message/

Bug: #86
Change-Id: I5b84160ae89b29b3903e53929ab444dc86b70056
@winstonsung
Copy link
Collaborator Author

Yeah, similar concept.

Example: https://github.com/wikimedia/mediawiki/blob/38066e5/languages/i18n/preferences/zh-hant.json

@winstonsung winstonsung self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winstonsung winstonsung

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@winstonsung @iach526526