Skip to content

global region does not support different resolutiosn #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pabloitu opened this issue Feb 23, 2022 · 2 comments · Fixed by #277
Closed

global region does not support different resolutiosn #187

pabloitu opened this issue Feb 23, 2022 · 2 comments · Fixed by #277
Assignees

Comments

@pabloitu
Copy link
Collaborator

lons = cleaner_range(-180.0, 179.9, dh)

Creating new global_regions fails when prompting dh greater than 0.1, because it provides spatial cells outside the globe range (e.g. 180.1 lon). It has to do with passing to cleaner_range a prescribed end of 179.9lon, 89.9 lat.

@wsavran
Copy link
Collaborator

wsavran commented Aug 18, 2022

@pabloitu is this issue still a problem. i can make a fix before the v0.6.1 release if that's the case.

@pabloitu pabloitu mentioned this issue Nov 25, 2024
24 tasks
@pabloitu pabloitu self-assigned this Feb 6, 2025
@pabloitu
Copy link
Collaborator Author

This issue is partially fixed with #255. After the merge or #270, this

pycsep/csep/core/regions.py

Lines 208 to 209 in d13f74f

lons = cleaner_range(-180.0, 179.9, dh)
lats = cleaner_range(-90, 89.9, dh)

should be modified to:

lons = cleaner_range(-180.0, 180.0, dh)[:-1]
lats = cleaner_range(-90.0, 90.0, dh)[:-1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants