Skip to content

EvaluationResult of Negative Binomial number test should return variance / alpha #261

@pabloitu

Description

@pabloitu

The evaluation function

def negative_binomial_number_test(gridded_forecast, observed_catalog, variance):
requires a variance parameter. However, this is not stored in the resulting EvaluationResult. To plot this negative binomial consistency test, the variance parameter is required again, which impedes the EvaluationResult to be a standalone object without the function arguments that created it. I propose to change
result.test_distribution = ('negative_binomial', fore_cnt)
to

    result.test_distribution = ('negative_binomial', fore_cnt, variance)

This would imply to remove the variance argument from the plot_consistency_test signature and retrieve it from the EvaluationResult argument the plot function has.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions