-
Notifications
You must be signed in to change notification settings - Fork 24
Fix to global plots #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to global plots #150
Conversation
…ument to plot_basemap. Does not define an extent in case that set_global is True. Also if set_global, region_border is modified to False to avoid global forecast edges when central_longitude is passed in the projection. Modified plot_customizations example to pass -179 as central_longitude. Values of 180 or -180 are not correctly handled by cartopy and pcolor functions fails to project appropiately.
build is failing because of obspy apparently |
interesting. i just merged 2 prs today and didn't run into this issue. all builds were successful. any idea why it might be failing? |
obspy/obspy#2651 these issues were supposedly fixed in the latest obspy release. it has to do with numpy dependencies it looks like. |
https://github.com/SCECcode/pycsep/runs/4098858335?check_suite_focus=true here is an example of a successful build. |
It failed too by now, like if there was some change in dependencies within those 3 hour difference in between Merges. I will try to check it, but should not be a problem of this PR, since the changes were minimum. |
Did not read this, but arrived to the exact same conclusion. It was fixed, but for some reason our CI its getting a different |
yeah i dont think we are seeing the same issue. in the past we had to pin numpy to 1.18.1 to solve this issue. it almost seems like there was some type of issue with the ci runner itself. im trying again to see if the problem was transient. i dont feel comfortable merging this until the ci issues are resolved. |
agreed. |
see this issue pypa/setuptools#2849. |
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 56.48% 56.48%
=======================================
Files 19 19
Lines 3233 3233
Branches 479 479
=======================================
Hits 1826 1826
Misses 1288 1288
Partials 119 119 Continue to review full report at Codecov.
|
@pabloitu pr looks good, will merge this after release of v.0.5.0. ill make a new release v0.5.1 with this change included. |
Fixes #144. Modified plot_spatial_dataset and plot_catalog to correctly handle Global plots. Updated plot_customizations example in the docs.
Type of change:
Checklist: