Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically Generating Functions for Slide/Doc/Sheet updates #369

Open
5 tasks done
FISHMANPET opened this issue Mar 28, 2022 · 0 comments
Open
5 tasks done

Dynamically Generating Functions for Slide/Doc/Sheet updates #369

FISHMANPET opened this issue Mar 28, 2022 · 0 comments
Assignees
Milestone

Comments

@FISHMANPET
Copy link
Collaborator

FISHMANPET commented Mar 28, 2022

I'm continuing the work @scrthq started in https://github.com/SCRT-HQ/PSGSuite/tree/feature/sheets_batch_update, currently in https://github.com/SCRT-HQ/PSGSuite/tree/release/2.37.0.

Currently everything "works" in that valid code is generated and it passes all tests (only help tests would apply here, I think).
There are a few things that need to be worked on though, to make it more complete. I'm working on these myself currently, but just want to ensure the work is tracked in case I get pulled away.

  • Invoke-HelperFunctionGeneration uses different parameter list code for generating function and determining sub-types to create
  • If the Request takes a System.Collections.Generic.IList for a list of some Google-specific type, a function to create that object is not generated
  • System.Collections.Generic.IList is not native to PowerShell and can be a little confusing and difficult to work with. Automate the conversation of simple PowerShell arrays into this type in Invoke-BatchUpdateFunctionGeneration, similar to how it's done in Invoke-HelperFunctionGeneration.
  • Same as above but with System.Collections.Generic.IDictionary. I added this HelperFunction, add it to BatchUpdateFunction as well
  • This is all built on a fair number of assumptions about the structure of these .Net objects, so add tests that verify these assumptions, in case future changes to the library make them no longer true (doubtful, but I already wrote most of the code for this anyway)
@FISHMANPET FISHMANPET self-assigned this Mar 28, 2022
@FISHMANPET FISHMANPET added this to the v2.37.0 milestone Mar 28, 2022
FISHMANPET added a commit that referenced this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant