Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for User Relation #130

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Add Support for User Relation #130

merged 4 commits into from
Dec 11, 2018

Conversation

mattwoolnough
Copy link
Contributor

@scrthq
Copy link
Member

scrthq commented Dec 11, 2018

Thanks for sending this over, @mattwoolnough!! Going to check it out ASAP, busy week this week!!

Copy link
Member

@scrthq scrthq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move $global:PSGSuite variable to Script scoped $script:PSGSuite variable on New-GSUser

@ghost ghost assigned scrthq Dec 11, 2018
@ghost ghost added the work in progress label Dec 11, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@scrthq scrthq merged commit f31f5c9 into SCRT-HQ:master Dec 11, 2018
@ghost ghost removed the work in progress label Dec 11, 2018
@scrthq
Copy link
Member

scrthq commented Dec 11, 2018

Merging this in, will get it deployed by this weekend once I add a few other pending items to the release! I'll comment on the original issue #129 once the additions are deployed to the PowerShell Gallery.

Thanks again, @mattwoolnough!!

@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@SCRT-HQ SCRT-HQ deleted a comment Dec 11, 2018
@scrthq
Copy link
Member

scrthq commented Dec 12, 2018

@mattwoolnough gotcha! That's awesome! If you feel there's value in using a Global scoped variable, I'm all ears. Happy to help solve a problem if it means less workarounds needed on your, or anyone else's, end!

@mattwoolnough
Copy link
Contributor Author

I don't think that my solution was the most elegant one, but it got me where I needed to be.

The issue is that there is no local file system from which to read the config file.

@scrthq
Copy link
Member

scrthq commented Dec 12, 2018

Interesting! How are you solving the lack of a file system? This would be a scenario I'd love to support, if possible!

scrthq added a commit that referenced this pull request Dec 19, 2018
## 2.21.0

* [PR #130](#130) / [Issue #129](#129)
  * Added: Support for UserRelations management in `New-GSUser -Relations $relations` and `Update-GSUser -Relations $relations` via `Add-GSUserRelation` helper function. - _Thanks, [@mattwoolnough](https://github.com/mattwoolnough)!_
  * Added: Logic to `Update-GSUser` to enable clearing of all values for user properties `Phones`, `ExternalIds`, `Organizations`, and `Relations` by REST API call via passing `$null` as the value when calling `Update-GSUser`. - _Thanks, [@mattwoolnough](https://github.com/mattwoolnough)!_
* [Issue #129](#129)
  * Fixed: Documentation for `Get-GSSheetInfo` around the `Fields` parameter.
  * Added: Additional correction of casing for `Fields` values in `Get-GSSheetInfo` so that it will always submit the values using the correct case, even if providing the incorrect case as the value to the parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants