Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gs group #353

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Update gs group #353

merged 4 commits into from
Apr 6, 2022

Conversation

Buenno
Copy link

@Buenno Buenno commented Jun 6, 2021

Added new Update-GSGroup function to resolve issue reported in #344.

I have also removed the email parameter from the Update-GSGroupSettings function as the groups settings API cannot be used to update the email address, you must use the directory API.

@FISHMANPET FISHMANPET added this to the v2.37.0 milestone Apr 1, 2022
Copy link
Collaborator

@FISHMANPET FISHMANPET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a release ready and I'd like to pull this in. One change though - Update-GSGroup doesn't have a file extension. If you could fix that, then I'll be able to merge it in.

Copy link
Collaborator

@FISHMANPET FISHMANPET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FISHMANPET FISHMANPET merged commit a550a73 into SCRT-HQ:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants