Skip to content
This repository has been archived by the owner on Oct 21, 2023. It is now read-only.

Add-ConIf does not allow bool #81

Closed
indented-automation opened this issue Jul 28, 2020 · 2 comments
Closed

Add-ConIf does not allow bool #81

indented-automation opened this issue Jul 28, 2020 · 2 comments
Assignees
Labels

Comments

@indented-automation
Copy link
Collaborator

Description

Add-ConIf -ConditionName IsActiveRegion -ValueIfTrue $true -ValueIfFalse $false

Steps to reproduce

Add-ConIf -ConditionName SomeConditionName -ValueIfTrue $true -ValueIfFalse $false

Expected result

A template should be generated like:

"Fn::If": [
    "SomeConditionName ",
    true,
    false
]

Actual result

An error is raised with an obscure parameter reference.

Add-ConIf: The ValueToImport parameter only accepts the following types: Vaporshell.Condition.If, Vaporshell.Function.Base64, Vaporshell.Function.FindInMap, Vaporshell.Function.GetAtt, Vaporshell.Function.GetAZs, Vaporshell.Function.Join, Vaporshell.Function.Select, Vaporshell.Function.Ref, System.String. The current types of the value are: System.Boolean, System.ValueType, System.Object.
@scrthq
Copy link
Member

scrthq commented Jul 31, 2020

Coming up soon @indented-automation !

image

scrthq added a commit that referenced this issue Jul 31, 2020
## 2.13.0 - 2020-07-30

* [Issue #81](#81)
    * Fixed: `Add-ConIf` parameter error message
    * Fixed: `Add-ConIf` now allows boolean values
* [Issue #82](#82)
    * Fixed: Condition Functions are now supported on any parameter that already accepts Intrinsic Functions
* Miscellaneous
    * Updated PseudoParameter list to current spec.
scrthq added a commit that referenced this issue Jul 31, 2020
## 2.13.0 - 2020-07-30

* [Issue #81](#81)
    * Fixed: `Add-ConIf` parameter error message.
    * Fixed: `Add-ConIf` now allows boolean values.
* [Issue #82](#82)
    * Fixed: Condition Functions are now supported on any parameter that already accepts Intrinsic Functions.
* Miscellaneous
    * Updated PseudoParameter list to current spec.
    * Switched default branch from `master`
@scrthq
Copy link
Member

scrthq commented Jul 31, 2020

Fix deployed with version 2.13.0.20200731!

image

@scrthq scrthq closed this as completed Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants