Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telem improve #103

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Telem improve #103

merged 9 commits into from
Jun 27, 2023

Conversation

pbulsink
Copy link
Collaborator

In partial of #78, allows for one of 'fastest', 'all', or a numbered lap's telemetry to be selected (but only for one driver). Also updates plot_fastest for new argument usage.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #103 (9919ae5) into master (c14b4cc) will increase coverage by 0.37%.
The diff coverage is 62.50%.

❗ Current head 9919ae5 differs from pull request most recent head 9284121. Consider uploading reports for the commit 9284121 to get more accurate results

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   86.83%   87.21%   +0.37%     
==========================================
  Files          18       18              
  Lines         471      485      +14     
==========================================
+ Hits          409      423      +14     
  Misses         62       62              
Impacted Files Coverage Δ
R/load_driver_telemetry.R 72.22% <60.00%> (-5.06%) ⬇️
R/plot_fastest.R 82.35% <100.00%> (ø)

... and 3 files with indirect coverage changes

@pbulsink
Copy link
Collaborator Author

I think if you restart that failed test it might pass? That build error is flaky

@SCasanova SCasanova merged commit a455e03 into SCasanova:master Jun 27, 2023
@pbulsink pbulsink deleted the telem-improve branch June 28, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants