Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConstructorId to results data, and new load_constructors() function #40

Closed
wants to merge 6 commits into from

Conversation

pbulsink
Copy link
Collaborator

@pbulsink pbulsink commented May 4, 2023

Partial resolution of #37.

pbulsink and others added 4 commits November 25, 2022 07:48
Badges - This is pulled to pbulsink/master to test actions/badges. If validated, will correct links to pull badge images from upstream (SCasanova/f1dataR)
@pbulsink
Copy link
Collaborator Author

pbulsink commented May 4, 2023

Note likely some test failures if fastf1 isn't available to the test suite - I have another PR ready to come with that resolved.

@pbulsink
Copy link
Collaborator Author

pbulsink commented May 4, 2023

My unfamiliarity with Github (and forgetting to wait between PR & more work in a branch) caused this commit & revert, sorry.

@SCasanova
Copy link
Owner

Hmm it seems checks have failed for some reason

@pbulsink
Copy link
Collaborator Author

pbulsink commented May 4, 2023

Ya there were some changes to fastf1 in their new version 3.0.0 (see https://github.com/theOehrly/Fast-F1/releases/tag/v3.0.0). I have changes ready to come that fix it but they currently require fastf1 >= 3.3.0. I might try make it more flexible to work differently depending on which version is installed, else it's a breaking change to the package for everyone who's on older fastf1 versions. I think I'll close this, bring in those changes, then reopen this PR.

@pbulsink pbulsink closed this May 4, 2023
pbulsink added a commit to pbulsink/f1dataR that referenced this pull request May 6, 2023
Reimplementing SCasanova#40 in partial resolution of SCasanova#37
@pbulsink pbulsink deleted the master branch May 22, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants