Remove script path in PlatformTests #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwichmann
added
testsuite
For Python 3.12+, cpython module "posixpath" test-imports 'posix', expecting it to fail on win32. However, for this one test program, since it's in SCons/Platform, that directory as the "script path" is in sys.path, and it finds our "posix" module, thus breaking things. This removes that element from the path - it's not put back because we don't actually need it here. Fixes SCons#4376 Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
force-pushed
the
test/posix-module
branch
from
c101de3
to
10f92a6
Compare
mwichmann
added a commit
to mwichmann/scons
that referenced
this pull request
Jul 27, 2023
Oops, missed that SCons/Platform/virtualenvTests.py needed the same hack as SCons/Platform/PlatformTests.py (in PR SCons#4381) Signed-off-by: Mats Wichmann <mats@linux.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Python 3.12+, cpython module
posixpathtest-importsposix, expecting it to fail on win32. However, for this one test program, since it's inSCons/Platform, that directory as the "script path" is insys.path, and it finds ourposixmodule, thus breaking things. This removes that element from the path - it's not put back because we don't actually need it here.Fixes #4376
Unrelated -
UtilTests.pyis moved down intoSCons/Util, to follow the usual naming conventions where the unit test is in the package dir.This is a test-only change, no impacts on SCons itself.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)