"Modernize" to Python 3.6 via tool #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ pyupgrade --py36-plus $(<filelist)
Here's mostly what it's done:
- No more 'stringliteral'.encode('utf-8'): now b'stringliteral'
- No more unicode literals
- the default open mode is 'r', leaves out if default
- some f-string conversions (if shorter)
- catch OSError instead of subclasses
- no more mention of "object"
- generator expression instead of list comp. when safe
- a few tests had a shebang but actually began with blank line
- remove coding: utf-8 comment, per pep 3120 this is the default now
Manually - if a file in test/ was modified, then did the copyright
header conversion.
Signed-off-by: Mats Wichmann <mats@linux.com>
|
The objective here is to not have to deal with these manually... |
Some of these got done in the tool conversion, some not, so picked up the rest manually. Signed-off-by: Mats Wichmann <mats@linux.com>
|
@mwichmann Is it possible to share the I have a handful of local branches that are not quite ready to be submitted yet. These "global" changes that modify a bunch of files are sometimes difficult (for me at least) to merge with the latest master. Running the pyupgrade script against the same file list would be a huge time saver. Any suggestions are welcome. |
|
Yes, sorry about that, they're a pain to deal with (me too, I have too many patchsets in flight). I don't think this is the one I used, but I've used this one for other checkers (renamed due to github restrictions) |
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ pyupgrade --py36-plus $(<filelist)
Here's mostly what it's done:
'stringliteral'.encode('utf-8'): nowb'stringliteral'OSErrorinstead of subclassesobjectcoding: utf-8comment, per pep 3120 this is the default nowManually - if a file in test/ was modified, then did the copyright header conversion.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)