Fix msvc stdout
issues with cl
/link
#4513
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a long-standing issue with msvc when using the
cl
/link
tools: theirstdout
choices are abysmal. They will always have a line of bloat with absolutely no arguments to circumvent it & will frequently put error messages onstdout
instead ofstderr
. This PR addresses both issues at once with a modified implementation of aSPAWN
fix used in the Godot repo1. The main change is this is directly built into the spawn function itself, branching off ifcl
orlink
is the leading argument.Contributor Checklist:
CHANGES.txt
(and read theREADME.rst
)Footnotes
https://github.com/godotengine/godot/pull/90551 ↩