Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle permission errors while generating paths on Darwin #4603

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

al3xtjames
Copy link
Contributor

@al3xtjames al3xtjames commented Sep 23, 2024

On Darwin, Nix may invoke SCons in a sandbox which lacks access to /etc/paths.d. Handle PermissionError while iterating through /etc/paths.d to support sandboxed environments such as Nix.

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated CHANGES.txt (and read the README.rst)
  • I have updated the appropriate documentation

@bdbaddog
Copy link
Contributor

Please add a blurb to CHANGES.txt and RELEASE.txt as requested in the Pull Request form...

@al3xtjames
Copy link
Contributor Author

Sorry, I updated CHANGES.txt but forgot to add it to the commit. Do any changes need to be made to RELEASE.txt?

@bdbaddog
Copy link
Contributor

Sorry, I updated CHANGES.txt but forgot to add it to the commit. Do any changes need to be made to RELEASE.txt?

Yes. Basically the same text, but in the proper section.
Makes it a lot easier to process a release if I don't need to edit both docs and make sure there's info in each for each PR..
Thanks!

On Darwin, Nix may invoke SCons in a sandbox which lacks access to
/etc/paths.d. Handle PermissionError while iterating through
/etc/paths.d to support sandboxed environments such as Nix.
@bdbaddog bdbaddog merged commit 4af2538 into SCons:master Sep 23, 2024
6 of 8 checks passed
@mwichmann mwichmann added this to the NextRelease milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants