Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump runner image to macos-15 #3757

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

YoloMao
Copy link
Contributor

@YoloMao YoloMao commented Sep 30, 2024

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...

Pull Request Description

Due to actions/runner-images#10559 , should download visionOS SDK before running workflow.

@YoloMao
Copy link
Contributor Author

YoloMao commented Sep 30, 2024

On the other hand, you can also change the runner image to macos-15 public beta

@YoloMao
Copy link
Contributor Author

YoloMao commented Sep 30, 2024

ci run failed because it take wrong version of visionOS, when running xcodebuild -downloadPlatform visionOS, the visionOS version is 1.2 but current Xcode is 15.2(DEVELOPER_DIR: /Applications/Xcode_15.2.app),shall we change Xcode version to 15.4?

@erik-bershel
Copy link

shall we change Xcode version to 15.4?

It's better to use Xcode 16.0 if you want to use latest visionOS simulator.

Simplest way is just to use macos-15 image instead of macos-14. But also might be done by switching using this:

    - uses: maxim-lobanov/setup-xcode@v1
      with:
        xcode-version: 16

@dreampiggy
Copy link
Contributor

dreampiggy commented Oct 8, 2024

I think switch to Xcode 16 + macOS 15 is OK.

During my local test, I don't found huge regression on macOS 15 (iOS 18 simulator)

@YoloMao
Copy link
Contributor Author

YoloMao commented Oct 8, 2024

Done. See see @dreampiggy, there is some tests run failed, should be outside of this pr.

@dreampiggy
Copy link
Contributor

dreampiggy commented Oct 8, 2024

The failed case test29ThatJFIFDecodeOrientationShouldNotApplyTwice, is a regression by design on iOS 18/tvOS 18/visionOS 2/watchOS 11, because I test some Apple's system framework (ImageIO.framework) behavior in that case, since Apple always change some internal details (but breaks SDWebImage's optimization)

You can just ignore this and I'll update the test case later.

@dreampiggy
Copy link
Contributor

LGTM

@dreampiggy dreampiggy merged commit a261180 into SDWebImage:master Oct 8, 2024
4 of 7 checks passed
@YoloMao YoloMao deleted the fix/visionOS branch October 8, 2024 07:33
@YoloMao YoloMao changed the title build: download visionOS SDK before CI/CD build: bump runner image to macos-15 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants