Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to request other type of PHAsset like Video during loading #10

Merged
merged 2 commits into from
Sep 20, 2019

Conversation

dreampiggy
Copy link
Collaborator

Feature Request

See #9

Solution

Add a option to disable the hard-coded filter for image asset. You can use Video Asset as well. And maybe some other asset type in future (like that unkown ?)

@dreampiggy
Copy link
Collaborator Author

I test that it works when using a video asset. PHImageManager will return the poster showing in Photos.app. Maybe it's the poster (or something more smart using the CoreML feature ?)

@dreampiggy dreampiggy mentioned this pull request Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #10 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   63.38%   63.52%   +0.14%     
==========================================
  Files           3        3              
  Lines         254      255       +1     
==========================================
+ Hits          161      162       +1     
  Misses         93       93
Flag Coverage Δ
#iOS 63.52% <100%> (+0.14%) ⬆️
Impacted Files Coverage Δ
...ImagePhotosPlugin/Classes/SDWebImagePhotosLoader.m 59.6% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc4ff3...34d5b69. Read the comment docs.

@dreampiggy dreampiggy merged commit fe25673 into master Sep 20, 2019
@dreampiggy dreampiggy deleted the feature_request_video_type_asset branch September 20, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant