Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use the ph:// URL format, to compatible with react-native-cameraroll #12

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

dreampiggy
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #12 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   63.52%   63.34%   -0.19%     
==========================================
  Files           3        3              
  Lines         255      251       -4     
==========================================
- Hits          162      159       -3     
+ Misses         93       92       -1
Flag Coverage Δ
#iOS 63.34% <100%> (-0.19%) ⬇️
Impacted Files Coverage Δ
...hotosPlugin/Classes/NSURL+SDWebImagePhotosPlugin.m 81.25% <100%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076f7b5...3c75018. Read the comment docs.

@dreampiggy dreampiggy merged commit 9af5988 into master Nov 22, 2019
@dreampiggy dreampiggy deleted the change_compatible_with_ph_scheme_react_native branch November 23, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant