Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add the support to use thumbnail size for querying Photos Asset #15

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

dreampiggy
Copy link
Collaborator

The Thumbnail Decoding feature is introduced in SDWebImage 5.5.0: https://github.com/SDWebImage/SDWebImage/wiki/Advanced-Usage#thumbnail-decoding-550

For Photos URL, unify the API can make it easy to use for some of users.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #15 into master will decrease coverage by 0.55%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   62.40%   61.85%   -0.56%     
==========================================
  Files           3        3              
  Lines         258      270      +12     
==========================================
+ Hits          161      167       +6     
- Misses         97      103       +6     
Flag Coverage Δ
#iOS 61.85% <40.00%> (-0.56%) ⬇️
Impacted Files Coverage Δ
...WebImagePhotosPlugin/Classes/SDImagePhotosLoader.m 58.10% <40.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063852b...46b9ad9. Read the comment docs.

@dreampiggy dreampiggy merged commit 38db280 into master Jul 10, 2020
@dreampiggy dreampiggy deleted the feature_thumbnail_size branch July 10, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant