Feature: add new context option to use request image data instead of request image API #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orAsset` API instead of `requestImageForAsset`, this may help for user who need raw image data and custom processing pipeline.
…vide a custom value.
dreampiggy
force-pushed
the
feature_request_image_data
branch
from
483f0bd
to
efe1960
Compare
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 63.38%
=========================================
Files ? 3
Lines ? 254
Branches ? 0
=========================================
Hits ? 161
Misses ? 93
Partials ? 0
Continue to review full report at Codecov.
|
dreampiggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a context option
SDWebImageContextPhotosRequestImageData, to always using therequestImageDataForAsset:options:resultHandler:API for Photos framework.This is useful for user, who need the raw image data, and have their image processing code. The default behavior only using this for animated images, which may not satisfy the use case.