Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy the macros from SDWebImage Core repo to fix build issue #98

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Copy the macros from SDWebImage Core repo to fix build issue #98

merged 2 commits into from
Feb 5, 2024

Conversation

dreampiggy
Copy link
Contributor

This close #97

Note

These macro don't need compile (that SDInternalMacros.m provided the symbol), just make the compiler be able to find the search path and expand is OK

Test

Tested on 3 Package Manager:

  • CocoaPods
  • Swift PM
  • Carthage (Still, well, it's here)

@dreampiggy
Copy the macros from SDWebImage Core repo
4005a4d 
These macro don't need compile (that SDInternalMacros.m provided the symbol), just make the compiler be able to find the search path and expand is OK
@dreampiggy
Fix the Example/Test warning
15d5bcb
@dreampiggy dreampiggy merged commit 1e39e3d into master Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failed after 0.14.4 release
1 participant
@dreampiggy