Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyside is deprecated in favor of Pyside2 #94

Closed
rhertzog opened this issue Jan 15, 2019 · 1 comment
Closed

Pyside is deprecated in favor of Pyside2 #94

rhertzog opened this issue Jan 15, 2019 · 1 comment

Comments

@rhertzog
Copy link

rhertzog commented Jan 15, 2019 •
edited
Loading

sparta relies on PySide.QtWebKit but PySide is deprecated in favor of PySide2 (https://wiki.qt.io/Qt_for_Python). You should consider switching to PySide2.

PySide2 provides PySide2.QtWebEngineCore and PySide2.QtWebEngineWidgets which hopefully provides similar functionalities to PySide.QtWebKit.

https://doc.qt.io/qtforpython/PySide2/QtWebEngineWidgets/index.html
https://doc.qt.io/qtforpython/PySide2/QtWebEngineCore/index.html
http://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html

FWIW, if this issue doesn't get resolved, it seems likely that we will have to drop sparta from Kali Linux.
This is tracked here in the Kali bug tracker: https://bugs.kali.org/view.php?id=4978

Thank you for your work on sparta!
mcjon3z added a commit to mcjon3z/sparta that referenced this issue Feb 19, 2019
@mcjon3z
Merge branch 'master' into mcjon3z-userpass-params
6d393ac 
* master:
  Update README.md
  Removed QtWebKit dependency (closes SECFORCE#94). Improved HTTPS/HTTP detection (closes SECFORCE#90). Removed check for ms08-067 from smbenum.sh
@st3r30byt3
Copy link
Contributor

We've ported SPARTA to Python3 and PyQt5. It should run on the latest Kali.

For now it's on the dev branch but we will push to master once more testing has been conducted:
https://github.com/SECFORCE/sparta/tree/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rhertzog @st3r30byt3