-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(glimps): use py-gdetect client + add get status and wait for result actions #1169
feat(glimps): use py-gdetect client + add get status and wait for result actions #1169
Conversation
033341e
to
9be9c26
Compare
25d44f3
to
a704637
Compare
a704637
to
0adeecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contrib ! 🎉
0adeecf
to
5894cdd
Compare
Test Results32 tests - 72 24 ✅ - 79 1s ⏱️ -1s Results for commit cda1034. ± Comparison against base commit 7ba5509. This pull request removes 104 and adds 32 tests. Note that renamed tests count towards both.
This pull request removes 1 skipped test and adds 8 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
+ Coverage 90.03% 90.58% +0.55%
==========================================
Files 61 69 +8
Lines 2790 3017 +227
Branches 103 103
==========================================
+ Hits 2512 2733 +221
- Misses 240 246 +6
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, and sorry for the delai of this review.
In order to not break existing automations, we have to keep the old actions.
Can you restore the declaration of the old actions and prefix their name with
[DEPRECATED]
? Same for the python code, can you restore it and maybe move it in a deprecated.py
file? Thank you.
c1c1daa
to
aed719a
Compare
aed719a
to
862cf51
Compare
862cf51
to
4901e72
Compare
@squioc @jeromefellus-sekoia @glimps-cbi plusieurs modifs faites :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes.
I detected an issue in main.py
.
Except this, the code looks good to me.
eab4229
to
3c779e5
Compare
Co-authored-by: Sébastien Quioc <sebastien.quioc@sekoia.fr>
3c779e5
to
758875e
Compare
@squioc I've tested the actions on our pre-prod platform via custom integration. Everything seems ok, all your comments have been applied. Ready for merge ? |
14b9466
to
69e76ee
Compare
oops hold on ! I pushed the wrong commit where I tampered the actions UUID to allow testing without shadowing on the pre-prod. Let me push the right commits, sorry about it |
fix(glimps): minor fixes to make glimps analysis action work
Head branch was pushed to by a user without write access
cb91e90
to
cda1034
Compare
Thanks @glimps-glv all good now |
…ult actions