Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESET actions #1248

Merged
merged 10 commits into from
Jan 23, 2025
Merged

Add ESET actions #1248

merged 10 commits into from
Jan 23, 2025

Conversation

lvoloshyn-sekoia
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Jan 13, 2025

Test Results

3 tests   - 50   3 ✅  - 46   0s ⏱️ -2s
1 suites ± 0   0 💤  -  4 
1 files   ± 0   0 ❌ ± 0 

Results for commit 55cfb15. ± Comparison against base commit 6b5f7a4.

This pull request removes 53 and adds 3 tests. Note that renamed tests count towards both.
tests.management_api.test_checkpoint ‑ test_checkpoint_greater_than_7_days
tests.management_api.test_checkpoint ‑ test_checkpoint_greater_than_7_days_bis
tests.management_api.test_checkpoint ‑ test_checkpoint_lesser_than_30_days
tests.management_api.test_checkpoint ‑ test_checkpoint_save_last_date
tests.management_api.test_checkpoint ‑ test_non_existing_checkpoint
tests.management_api.test_client ‑ test_activate_subscription_should_exception_on_http_error
tests.management_api.test_client ‑ test_activate_subscription_should_exception_when_handling_business_error
tests.management_api.test_client ‑ test_active_subscription_should_succeed
tests.management_api.test_client ‑ test_get_content
tests.management_api.test_client ‑ test_get_content_should_exception_on_http_error
…
tests.test_actions ‑ test_action_deisolate
tests.test_actions ‑ test_action_isolate
tests.test_actions ‑ test_eset_scan_action

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (4075ac2) to head (55cfb15).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1248      +/-   ##
==========================================
+ Coverage   90.45%   93.61%   +3.16%     
==========================================
  Files           7       15       +8     
  Lines         220      329     +109     
==========================================
+ Hits          199      308     +109     
  Misses         21       21              
Flag Coverage Δ
Eset 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvoloshyn-sekoia lvoloshyn-sekoia marked this pull request as ready for review January 14, 2025 08:21
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work.
There is a change to apply due to an error in the specification (Sorry).

Eset/eset_modules/client/auth.py Outdated Show resolved Hide resolved
Eset/eset_modules/action_isolate_endpoint.py Outdated Show resolved Hide resolved
Eset/eset_modules/action_deisolate_endpoint.py Outdated Show resolved Hide resolved
Eset/eset_modules/action_scan.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the work.

@squioc squioc merged commit 70f8053 into main Jan 23, 2025
18 checks passed
@squioc squioc deleted the lv/add_eset_actions branch January 23, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants