Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mimecast verify that fetch date is after then 7 days ago #1261

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

vg-svitla
Copy link
Collaborator

No description provided.

@vg-svitla vg-svitla requested a review from squioc January 24, 2025 15:30
Copy link

github-actions bot commented Jan 24, 2025

Test Results

10 tests  +6   10 ✅ +6   1s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cf094b4. ± Comparison against base commit 6085c94.

This pull request removes 4 and adds 10 tests. Note that renamed tests count towards both.
tests.test_actions ‑ test_delete_message
tests.test_actions ‑ test_forward_message
tests.test_actions ‑ test_get_message
tests.test_actions ‑ test_update_message
tests.test_helpers ‑ test_get_upper_second
tests.test_mimecast_siem_logs ‑ test_authentication_failed
tests.test_mimecast_siem_logs ‑ test_fetch_batches
tests.test_mimecast_siem_logs ‑ test_most_recent_datetime_seen
tests.test_mimecast_siem_logs ‑ test_permission_denied
tests.test_mimecast_siem_logs ‑ test_start_consumers
tests.test_mimecast_siem_logs ‑ test_stop_consumers
tests.test_mimecast_siem_logs ‑ test_supervise_consumers
tests.test_retry ‑ test_get_retry_after
tests.test_retry ‑ test_parse_ratelimit_retry_after

♻️ This comment has been updated with latest results.

@vg-svitla vg-svitla requested a review from a team January 24, 2025 15:38
@vg-svitla vg-svitla requested a review from squioc January 24, 2025 16:12
Copy link
Collaborator

@squioc squioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squioc squioc merged commit 134e669 into main Jan 24, 2025
196 of 199 checks passed
@squioc squioc deleted the hotfix/mimecast_start_date_verification branch January 24, 2025 17:08
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (6085c94) to head (cf094b4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...mecast/mimecast_modules/connector_mimecast_siem.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   89.98%   89.96%   -0.03%     
==========================================
  Files          70       70              
  Lines        2886     2890       +4     
  Branches      106      106              
==========================================
+ Hits         2597     2600       +3     
- Misses        250      251       +1     
  Partials       39       39              
Flag Coverage Δ
Mimecast 81.09% <42.85%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants